Repository navigation
Conversation
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryAdds
No actionable issues were found. Tests were inspected but not run during this review. Acknowledged scope: Reviews (1) · Last reviewed commit: "feat(user-management): Add authorized ap..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds two missing endpoints to
workos.userManagement:Uses the current official OpenAPI schema, including granted scopes, optional OAuth resource, and the nested application. Adds public types available through Node and worker exports.
References the unmerged implementation in #1536, following existing SDK conventions rather than introducing generator changes, as in #1681. Existing pagination options and defaults remain unchanged.
Tests cover request methods and paths, pagination parameters and subsequent pages, response deserialization, encoded IDs, and empty deletion responses.
Note:
The API also supports
order: "normal", but the SDK’s shared pagination type does not expose it, including foruserManagement.listUsers. Because adding it would be out of the scope of this PR, the new methods also don't alloworder: "normal".Verification
Documentation
The endpoints are already documented. No documentation changes are required for this SDK addition.